Re: [Announce] submitGit for patch submission (was "Diffing submodule does not yield complete logs")

Roberto Tyley [off-list ref] writes:

Hello, I'm stepping up to do that work :) Or at least, I'm implementing a
one-way GitHub PR -> Mailing list tool, called submitGit:

https://submitgit.herokuapp.com/

Yay ;-)

Here's what a user does:

* create a PR on https://github.com/git/git
* logs into https://submitgit.herokuapp.com/ with GitHub auth
* selects their PR on https://submitgit.herokuapp.com/git/git/pulls

Reasonable.

* gets submitGit to email the PR as patches to themselves, in order to
check it looks ok

I can see you are trying to be careful by doing this, but I am not
sure if this step would actually help. Those who are not familiar
with Git development are not expected to know what is "ok" in their
original commit, and if they find bad formatting done by submitGit
(e.g. adds their PR message before the three-dash line instead of
after it), they cannot do much about it anyway.

* when they're ready, get submitGit to send it to the mailing list on
their behalf

Nice.

All discussion of the patch *stays* on the mailing list

Can you identify a reroll of an earlier submission?  If you can use
the in-reply-to and make it a follow-up to the previous round, that
would be great.

From: "Junio C Hamano" <redacted>

Roberto Tyley [off-list ref] writes:

quoted

Hello, I'm stepping up to do that work :) Or at least, I'm 
implementing a
one-way GitHub PR -> Mailing list tool, called submitGit:

https://submitgit.herokuapp.com/

Yay ;-)

quoted

Here's what a user does:

* create a PR on https://github.com/git/git
* logs into https://submitgit.herokuapp.com/ with GitHub auth
* selects their PR on https://submitgit.herokuapp.com/git/git/pulls

Reasonable.

quoted

* gets submitGit to email the PR as patches to themselves, in order 
to
check it looks ok

I can see you are trying to be careful by doing this, but I am not
sure if this step would actually help. Those who are not familiar
with Git development are not expected to know what is "ok" in their
original commit, and if they find bad formatting done by submitGit
(e.g. adds their PR message before the three-dash line instead of
after it), they cannot do much about it anyway.

I still think this is valuable for the spotting of the dumb mistakes we 
all make, and notice after the fact when we see the email in the hard 
light of day. There will still be poor commit messages and the like, but 
at least the raw content is more likely to be as the author desired.

quoted

* when they're ready, get submitGit to send it to the mailing list on
their behalf

Nice.

quoted

All discussion of the patch *stays* on the mailing list

Can you identify a reroll of an earlier submission?  If you can use
the in-reply-to and make it a follow-up to the previous round, that
would be great.
--

Philip 

Ok, I am trying it out now, all I have left is

    Register your email address
    (stefanbeller@googlemail.com)
    with submitGit's Amazon SES
    account in order for it to send
    emails from you.

So first of all:
Where do I find the Amazon SES account for submitGit, to register
my email with?

Also can I change the email in the process or change it before?

Thanks,
Stefan

Hi Stefan,

On 2015-05-22 21:23, Stefan Beller wrote:

Ok, I am trying it out now, all I have left is

    Register your email address
    (stefanbeller@googlemail.com)
    with submitGit's Amazon SES
    account in order for it to send
    emails from you.

So first of all:
Where do I find the Amazon SES account for submitGit, to register
my email with?

Also can I change the email in the process or change it before?

FWIW I did not have to register my email. All I needed to do was to give submitGit permissions to read my personal email address and my public repositories.

Ciao,
Dscho

On Fri, May 22, 2015 at 12:59 PM, Johannes Schindelin
[off-list ref] wrote:

On 2015-05-22 21:23, Stefan Beller wrote:

quoted

So first of all:
Where do I find the Amazon SES account for submitGit, to register
my email with?

Also can I change the email in the process or change it before?

FWIW I did not have to register my email. All I needed to do was to give submitGit
permissions to read my personal email address and my public repositories.

Hmph, I was asked way more than that (especially, read and write access).
Does the site ask different authorizations depending on who you are?

On Fri, May 22, 2015 at 1:04 PM, Junio C Hamano [off-list ref] wrote:

On Fri, May 22, 2015 at 12:59 PM, Johannes Schindelin
[off-list ref] wrote:

quoted

On 2015-05-22 21:23, Stefan Beller wrote:

quoted

So first of all:
Where do I find the Amazon SES account for submitGit, to register
my email with?

Also can I change the email in the process or change it before?

FWIW I did not have to register my email. All I needed to do was to give submitGit
permissions to read my personal email address and my public repositories.

Hmph, I was asked way more than that (especially, read and write access).
Does the site ask different authorizations depending on who you are?

I was also asked for read/write on my copy of git, but as I am not
the maintainer nor trusted in any way, I figured that's ok.
I still have my local copy which would notice any changes on git push.

The question I was asking was the only thing I could not answer
or decide for myself.

Hi Junio,

On 2015-05-22 22:04, Junio C Hamano wrote:

On Fri, May 22, 2015 at 12:59 PM, Johannes Schindelin
[off-list ref] wrote:

quoted

On 2015-05-22 21:23, Stefan Beller wrote:

quoted

So first of all:
Where do I find the Amazon SES account for submitGit, to register
my email with?

Also can I change the email in the process or change it before?

FWIW I did not have to register my email. All I needed to do was to give submitGit
permissions to read my personal email address and my public repositories.

Hmph, I was asked way more than that (especially, read and write access).
Does the site ask different authorizations depending on who you are?

Well, I did not try to send to the mailing list yet. Maybe that's the difference? Or maybe it is because I just registered with Heroku before...

Ciao,
Dscho