Re: [PATCH] checkout-index.c: Unconditionally free memory

Jeff King [off-list ref] writes:

On Fri, May 01, 2015 at 03:35:37PM -0700, Stefan Beller wrote:

quoted

Subject: Re: [PATCH] checkout-index.c: Unconditionally free memory

Looks like the patch has expanded beyond checkout-index.c. Maybe:

  unconditionally free result of prefix_path

would be more descriptive? I usually like the "area:" prefix, but I
think here the common thread is not an area, but that they are return
values from prefix_path.

Sure, the prefix could even be "prefix_path(): $message", I would
think.

On Sat, May 02, 2015 at 07:15:08PM -0700, Junio C Hamano wrote:

Jeff King [off-list ref] writes:

quoted

On Fri, May 01, 2015 at 03:35:37PM -0700, Stefan Beller wrote:

quoted

Subject: Re: [PATCH] checkout-index.c: Unconditionally free memory

Looks like the patch has expanded beyond checkout-index.c. Maybe:

  unconditionally free result of prefix_path

would be more descriptive? I usually like the "area:" prefix, but I
think here the common thread is not an area, but that they are return
values from prefix_path.

Sure, the prefix could even be "prefix_path(): $message", I would
think.

I almost suggested that, but it not a change to prefix_path at all, but
rather to its callers. That may be getting nit-picky, though. :)

-Peff