Re: [PATCH] RFC/Add documentation for version protocol 2

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] RFC/Add documentation for version protocol 2

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:04:31

Stefan Beller [off-list ref] writes:
quoted
quoted
+action           = "noop" / "ls-remote" / "fetch" / "push" / "fetch-shallow"
...
quoted
If we are going in this "in-protocol message switches the service"
route, we should also support "archive" as one of the actions, no?
Yes, I know you named the document "pack-protocol" and "archive"
does not give you packs, but "ls-remote" does not transfer pack data,
either.
I'll add that. Also I need to incorporate shallow in one way or another.
This level of detail may not matter at this point yet, but it is
unclear to me why you have "fetch-shallow" as a separate thing
(while not having "push-shallow").  The current infrastructure does
already allow fetching into shallow repositories witout needing a
separate action that is different from "fetch" (aka "upload-pack").
I would not be surprised if it were "I can deepn you if you want"
capability, but I do not understand why you are singling out
"shallow" as something that needs such a special treatment.

Re: [PATCH] RFC/Add documentation for version protocol 2

From: Stefan Beller <hidden>
Date: 2016-06-15 23:04:31

On Wed, Apr 22, 2015 at 4:30 PM, Junio C Hamano [off-list ref] wrote:
Stefan Beller [off-list ref] writes:
quoted
quoted
quoted
+action           = "noop" / "ls-remote" / "fetch" / "push" / "fetch-shallow"
...
quoted
If we are going in this "in-protocol message switches the service"
route, we should also support "archive" as one of the actions, no?
Yes, I know you named the document "pack-protocol" and "archive"
does not give you packs, but "ls-remote" does not transfer pack data,
either.
I'll add that. Also I need to incorporate shallow in one way or another.
This level of detail may not matter at this point yet, but it is
unclear to me why you have "fetch-shallow" as a separate thing
(while not having "push-shallow").
Right, this should have been done via plain fetch action but the mode parameter
may be set to shallow,narrow or what we want. Sorry for my shortcut in thinking
there.
The current infrastructure does
already allow fetching into shallow repositories without needing a
separate action that is different from "fetch" (aka "upload-pack").
I would not be surprised if it were "I can deepn you if you want"
capability, but I do not understand why you are singling out
"shallow" as something that needs such a special treatment.
I should not have done that. I just got confused.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help