Re: [PATCH v8 1/4] sha1_file.c: support reading from a loose object of unknown type

karthik nayak [off-list ref] writes:

+       type = type_from_string_gently(buf, len, 1);
+       if (oi->typename) {
+               strbuf_add(oi->typename, buf, len);
+               strbuf_addch(oi->typename, '\0');

add() has setlen() at the end so you do not have to NUL terminate it
yourself.  Doing addch() is actively wrong, as oi->typename->len now
counts the terminating NUL as part of the string, no?

On 04/18/2015 12:53 AM, Junio C Hamano wrote:

karthik nayak [off-list ref] writes:

quoted

+       type = type_from_string_gently(buf, len, 1);
+       if (oi->typename) {
+               strbuf_add(oi->typename, buf, len);
+               strbuf_addch(oi->typename, '\0');

add() has setlen() at the end so you do not have to NUL terminate it
yourself.  Doing addch() is actively wrong, as oi->typename->len now
counts the terminating NUL as part of the string, no?

Yes. was speculative of that. thanks for clearing it up.