Re: [PATCH 1/3] t/lib-httpd: load mod_unixd

Torsten Bögershausen venit, vidit, dixit 08.04.2015 23:47:

On 2015-04-08 17.05, Michael J Gruber wrote:

quoted

With the current config, apache 2.4.10 will not be started and the httpd
tests will not run.

Enable mod_unixd to make the httpd tests run.

Signed-off-by: Michael J Gruber <redacted>
---

Notes:
    Basically, this is required since the switch from 2.2 to 2.4.
    I'm wondering whether noone is running these tests, or other
    distros (than Fedora) use different default configs.

Do you have any special test numbers in mind  ?
The following are running under Debian:

*** t5541-http-push-smart.sh ***
*** t5542-push-http-shallow.sh ***
*** t5550-http-fetch-dumb.sh ***
*** t5551-http-fetch-smart.sh ***
*** t5560-http-backend-noserver.sh ***

(Then I stopped digging)

And this under Mac OS, 
*** t5541-http-push-smart.sh ***
You do not seem to have gpg installed
ok 1 - setup remote repository
....

Is this with apache 2.4?

In my case (apache 2.4, fedora 21), t/lib-http.sh failed to start the
web server, so the tests above would (succeed trivially but) not run.

Maybe debian is using an apache default config that has mod_unixd built
in, to ease the transition from apache 2.2? Many were bitten by these
new requirements after the switch to 2.4, and some distros may have
worked around that.

Do your tests run with this patch applied?

Michael

On Thu, Apr 09, 2015 at 11:27:49AM +0200, Michael J Gruber wrote:

In my case (apache 2.4, fedora 21), t/lib-http.sh failed to start the
web server, so the tests above would (succeed trivially but) not run.

Maybe debian is using an apache default config that has mod_unixd built
in, to ease the transition from apache 2.2? Many were bitten by these
new requirements after the switch to 2.4, and some distros may have
worked around that.

Yes, this is exactly it. On my Debian system:

  $ apache2 -l
  Compiled in modules:
    core.c
    mod_so.c
    mod_watchdog.c
    http_core.c
    mod_log_config.c
    mod_logio.c
    mod_version.c
    mod_unixd.c

Do your tests run with this patch applied?

Yes. I think your patch is fine, as the IfModule means we handle both
the built-in and dynamic cases.

-Peff