Re: [PATCH] fix global bash variable leak on __gitcompappend

"Márcio Almada" [off-list ref] writes:

---
 contrib/completion/git-completion.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Nicely found and corrected.  Please sign-off your patch and Cc area
experts if you can find them (I'll do that this time for you).

Thanks.

Quoting Junio C Hamano [off-list ref]:

"Márcio Almada" [off-list ref] writes:

quoted

---
 contrib/completion/git-completion.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Nicely found and corrected.  Please sign-off your patch and Cc area
experts if you can find them (I'll do that this time for you).

Thanks.

quoted

diff --git a/contrib/completion/git-completion.bash  

b/contrib/completion/git-completion.bash
index 661a829..1620546 100644

--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash

@@ -186,7 +186,7 @@ fi

 __gitcompappend ()
 {
-	local i=${#COMPREPLY[@]}
+	local x i=${#COMPREPLY[@]}
 	for x in $1; do
 		if [[ "$x" == "$3"* ]]; then
 			COMPREPLY[i++]="$2$x$4"

Looks good and obviously correct, imho even at -rc2 time.

Not sure whether it's maint-worthy, but just in case: it was  
introduced in v1.8.3-rc0~59^2~2.

2015-04-09 0:56 GMT-03:00 Junio C Hamano [off-list ref]:

"Márcio Almada" [off-list ref] writes:

quoted

---
 contrib/completion/git-completion.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Nicely found and corrected.  Please sign-off your patch and Cc area
experts if you can find them (I'll do that this time for you).

Thanks.

Ok, I'll remember this next time. Thanks for your incredible work here.

quoted

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 661a829..1620546 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash

@@ -186,7 +186,7 @@ fi

 __gitcompappend ()
 {
-     local i=${#COMPREPLY[@]}
+     local x i=${#COMPREPLY[@]}
      for x in $1; do
              if [[ "$x" == "$3"* ]]; then
                      COMPREPLY[i++]="$2$x$4"

On Thu, Apr 9, 2015 at 9:52 AM, Marcio Almada [off-list ref] wrote:

2015-04-09 0:56 GMT-03:00 Junio C Hamano [off-list ref]:

quoted

"Márcio Almada" [off-list ref] writes:

quoted

 contrib/completion/git-completion.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Nicely found and corrected.  Please sign-off your patch and Cc area
experts if you can find them (I'll do that this time for you).

Ok, I'll remember this next time. Thanks for your incredible work here.

Junio's implication was that you should reply to his message with:

    Signed-off-by: Your Name <your@email>

Or re-send the patch with your sign-off added.