Re: git 2.3.4, ssh: Could not resolve hostname

Torsten Bögershausen [off-list ref] writes:

This makes my think that it is
a) non-standard to have the extra colon
b) The error message could be better

For that, perhaps

-ssh: Could not resolve hostname xxxx:: nodename nor servname provided, or not known
+ssh: Could not resolve hostname "xxxx:": nodename nor servname provided, or not known

would be something we would want to do, no matter what other fixes
we would apply.

Spontaneously I would say that a trailing ':' at the end of a
hostname in the ssh:// scheme can be safely ignored, what do you
think?

If it is not too much hassle to make the current code do so, I'd say
that is a good way forward.  Giving a warning that lets the user
know that the input has an extra and unwanted colon in it may be a
plus, too.

Thanks.

On Fri, Apr 03, 2015 at 02:01:55PM -0700, Junio C Hamano wrote:

Torsten Bögershausen [off-list ref] writes:

quoted

This makes my think that it is
a) non-standard to have the extra colon
b) The error message could be better

For that, perhaps

-ssh: Could not resolve hostname xxxx:: nodename nor servname provided, or not known
+ssh: Could not resolve hostname "xxxx:": nodename nor servname provided, or not known

would be something we would want to do, no matter what other fixes
we would apply.

That message comes from the ssh client. So the "we" here would have to submit a
patch to OpenSSH".

The easier way to diagnose inside git is to set GIT_TRACE, which makes
it more clear:

  $ GIT_TRACE=1 git clone ssh://bogosity:/repo.git
  ...
  17:05:00.734019 run-command.c:347       trace: run_command: 'ssh' 'bogosity:' 'git-upload-pack '\''/repo.git'\'''

-Peff