Re: [PATCH v4 3/4] docs/git-credential-store: document XDG file and precedence

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH v4 3/4] docs/git-credential-store: document XDG file and precedence

From: Matthieu Moy <hidden>
Date: 2016-06-15 23:04:12

I would personnally prefer to see this squashed with PATCH 2/4: pushing
the "bisectable history" principle a bit, the state between patches 2
and 3 could be considered broken because the code does not do what the
documentation says. And as a reviewer, I like having pieces of docs
linked to the patch they document.

Paul Tan [off-list ref] writes:
+Credential storage will per default
Not a native, but "per default" sounds weird and "by default" seems far
more common.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

Re: [PATCH v4 3/4] docs/git-credential-store: document XDG file and precedence

From: Paul Tan <hidden>
Date: 2016-06-15 23:04:14

Hi,

On Thu, Mar 19, 2015 at 12:23 AM, Matthieu Moy
[off-list ref] wrote:
I would personnally prefer to see this squashed with PATCH 2/4: pushing
the "bisectable history" principle a bit, the state between patches 2
and 3 could be considered broken because the code does not do what the
documentation says. And as a reviewer, I like having pieces of docs
linked to the patch they document.
Yup, I can see what you mean. Will squash on the next version.
Paul Tan [off-list ref] writes:
quoted
+Credential storage will per default
Not a native, but "per default" sounds weird and "by default" seems far
more common.
Ah right, that definitely sounds better. Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help