Re: git submodule: update=!command

Ryan Lortie [off-list ref] writes:

On Tue, Mar 17, 2015, at 16:49, Junio C Hamano wrote:

quoted

With more recent versions of Git, namely, the versions after
30a52c1d (Merge branch 'ms/submodule-update-config-doc' into maint,
2015-03-13), the documentation pages already have updated
descriptions around this area.

sigh.

That's what I get for forgetting to type 'git pull' before writing a
patch.

Sorry for the noise!

Nothing to apologise or sigh about.  You re-confirmed that the old
documentation was lacking, which led to an earlier discussion which
in turn led to Michal to update the documentation.  If you check the
output from

    git diff 30a52c1d^ 30a52c1d

and find it appropriately address the problem you originally had,
that would be wonderful, and if you can suggest further improvement,
that is equally good.

Thanks for participating in our effort to collectively make Git
better.

kara,

On Tue, Mar 17, 2015, at 17:05, Junio C Hamano wrote:

If you check the output from

    git diff 30a52c1d^ 30a52c1d

and find it appropriately address the problem you originally had,
that would be wonderful, and if you can suggest further improvement,
that is equally good.

Indeed, the new version of the docs looks much better.  I'm particularly
happy about the change to the format to make it easier to visually scan
for the possible update modes.

Cheers

On Wed, Mar 18, 2015 at 10:05 AM, Junio C Hamano [off-list ref] wrote:

Ryan Lortie [off-list ref] writes:

quoted

On Tue, Mar 17, 2015, at 16:49, Junio C Hamano wrote:

quoted

With more recent versions of Git, namely, the versions after
30a52c1d (Merge branch 'ms/submodule-update-config-doc' into maint,
2015-03-13), the documentation pages already have updated
descriptions around this area.

sigh.

That's what I get for forgetting to type 'git pull' before writing a
patch.

Sorry for the noise!

Nothing to apologise or sigh about.  You re-confirmed that the old
documentation was lacking, which led to an earlier discussion which
in turn led to Michal to update the documentation.  If you check the
output from

    git diff 30a52c1d^ 30a52c1d

and find it appropriately address the problem you originally had,
that would be wonderful, and if you can suggest further improvement,
that is equally good.

I think 30a52c1d could be improved with the following snippet from Ryans patch.

"For security reasons, this feature is not supported from the
`.gitmodules` file"

Or something along those lines.

On Wed, Mar 18, 2015 at 8:43 PM, Chris Packham [off-list ref] wrote:

On Wed, Mar 18, 2015 at 10:05 AM, Junio C Hamano [off-list ref] wrote:

quoted

Ryan Lortie [off-list ref] writes:

quoted

On Tue, Mar 17, 2015, at 16:49, Junio C Hamano wrote:

quoted

With more recent versions of Git, namely, the versions after
30a52c1d (Merge branch 'ms/submodule-update-config-doc' into maint,
2015-03-13), the documentation pages already have updated
descriptions around this area.

sigh.

That's what I get for forgetting to type 'git pull' before writing a
patch.

Sorry for the noise!

Nothing to apologise or sigh about.  You re-confirmed that the old
documentation was lacking, which led to an earlier discussion which
in turn led to Michal to update the documentation.  If you check the
output from

    git diff 30a52c1d^ 30a52c1d

and find it appropriately address the problem you originally had,
that would be wonderful, and if you can suggest further improvement,
that is equally good.

I think 30a52c1d could be improved with the following snippet from Ryans patch.

"For security reasons, this feature is not supported from the
`.gitmodules` file"

Or something along those lines.

Which is actually down the bottom if I take the time to read the whole diff.