Re: [PATCH 03/16] list-files: show paths relative to cwd

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 03/16] list-files: show paths relative to cwd

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:04:10

Duy Nguyen [off-list ref] writes:
Exactly. We would need to sort and stuff later on, so true filenames
are preserved in util->item. A cleaner way is perhaps carry all
metadata in item->util and item->string remains true filename, then do
all the formatting, coloring for all strings just before displaying.
I guess we are then in agreement with my review comment on [04/16].

Thanks.

Re: [PATCH 03/16] list-files: show paths relative to cwd

From: Duy Nguyen <hidden>
Date: 2016-06-15 23:04:10

On Mon, Mar 16, 2015 at 4:16 AM, Junio C Hamano [off-list ref] wrote:
Duy Nguyen [off-list ref] writes:
quoted
Exactly. We would need to sort and stuff later on, so true filenames
are preserved in util->item. A cleaner way is perhaps carry all
metadata in item->util and item->string remains true filename, then do
all the formatting, coloring for all strings just before displaying.
I guess we are then in agreement with my review comment on [04/16].
Yes. I'm redoing it. I will probably stop using string-list as well
(it's inherited from the old code), just an array of struct.
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help