Re: [PATCH] git: make "git -C '' <cmd>" not to barf

Karthik Nayak [off-list ref] writes:

now it works like cd "" which silently succeeds

Missing "." at end of sentence.

 git.c | 4 +++-

That would probably also deserve a test.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

On Tue, Mar 3, 2015 at 8:22 AM, Matthieu Moy
[off-list ref] wrote:

Karthik Nayak [off-list ref] writes:

quoted

now it works like cd "" which silently succeeds

Missing "." at end of sentence.

And lack of capitalization at the beginning.

More importantly, lack of justification--why is it a good idea to make
"it works like cd ''" in the first place?

quoted

 git.c | 4 +++-

That would probably also deserve a test.

Another "huh?" I had on the actual code was if this counts as "envchanged", if
you are not actually changing the directory at all.

Is this meant as a "micro" for GSoC, by the way?

On March 3, 2015 11:30:13 PM GMT+05:30, Junio C Hamano [off-list ref] wrote:

On Tue, Mar 3, 2015 at 8:22 AM, Matthieu Moy
[off-list ref] wrote:

quoted

Karthik Nayak [off-list ref] writes:

quoted

now it works like cd "" which silently succeeds

Missing "." at end of sentence.

And lack of capitalization at the beginning.

Yes, noted, Will fix with next patch.

More importantly, lack of justification--why is it a good idea to make
"it works like cd ''" in the first place?

quoted

quoted

 git.c | 4 +++-

That would probably also deserve a test.

Will include a patch with next patch version.

Another "huh?" I had on the actual code was if this counts as
"envchanged", if
you are not actually changing the directory at all.

Is this meant as a "micro" for GSoC, by the way?

Yes, it's meant for GSoC.
I did overlook that. Will fix in next patch version. 
Thanks for your suggestions