Re: [PATCH 5/7] receive-pack: move execute_commands_non_atomic before execute_commands

Stefan Beller [off-list ref] writes:

Notes:
    This patch is new with v6 of the series
    
    As execute_commands_non_atomic is larger than execute_commands, the diff
    is not moving around execute_commands_non_atomic, but execute_commands.

;-)

Next time perhaps try "--patience" to decide between with and
without which one reads better?

I tried all four diff options as listed in the man page of
format-diff. I forget which one I used, but there was no large
difference w.r.t. reviewability if I remember correctly.


On Mon, Dec 22, 2014 at 10:19 AM, Junio C Hamano [off-list ref] wrote:

Stefan Beller [off-list ref] writes:

quoted

Notes:
    This patch is new with v6 of the series

    As execute_commands_non_atomic is larger than execute_commands, the diff
    is not moving around execute_commands_non_atomic, but execute_commands.

;-)

Next time perhaps try "--patience" to decide between with and
without which one reads better?