Adri sent me this directly but I think it should have gone to the list.
Adri, if you don't mind, Junio can add:
Tested-by: Adri Farr <redacted>
...to the commit message trailer since it looks like it's happy.
Thanks for testing!
cheers,
David
----- Forwarded message from Adri Farr [off-list ref] -----
Date: Sat, 15 Nov 2014 00:10:12 +0100
From: Adri Farr <redacted>
To: David Aguilar <redacted>
Subject: Re: [PATCH] difftool: honor --trust-exit-code for builtin tools
I have tested this patch both in vim and meld and it works
wonderfully. Thank you for the time put into this. I should have
provided feedback back when the patch was proposed. I guess it's never
too late :).
2014-11-14 22:57 GMT+01:00 David Aguilar [off-list ref]:
[snip]
----- End forwarded message -----
Oh, sorry about that. I didn't realize I was directly responding to
you. Apologizes. Hopefully I'm doing it right this time. I don't have
much experience with mailing lists, and Gmail doesn't seem to help.
You don't need to add the 'Tested-by' line. Testing is the least I can
do. If you still want to add that line, my full name is 'Adria
Farres'. Thank you!
2014-11-15 1:27 GMT+01:00 David Aguilar [off-list ref]:
Adri sent me this directly but I think it should have gone to the list.
Adri, if you don't mind, Junio can add:
Tested-by: Adri Farr <redacted>
...to the commit message trailer since it looks like it's happy.
Thanks for testing!
cheers,
David
----- Forwarded message from Adri Farr [off-list ref] -----
Date: Sat, 15 Nov 2014 00:10:12 +0100
From: Adri Farr <redacted>
To: David Aguilar <redacted>
Subject: Re: [PATCH] difftool: honor --trust-exit-code for builtin tools
I have tested this patch both in vim and meld and it works
wonderfully. Thank you for the time put into this. I should have
provided feedback back when the patch was proposed. I guess it's never
too late :).
2014-11-14 22:57 GMT+01:00 David Aguilar [off-list ref]:
quoted
[snip]
----- End forwarded message -----