Re: [PATCH v2 00/23] backend-struct-db

Ronnie Sahlberg [off-list ref] writes:

15 of the patches, the refs-common.c patches, focuses on moving all backend
agnostic refs functions to a common file. This file will contain all
backend agnostic refs functions.

The last 6 patches adds a backend structure with the methods we need to
describe a pluggable backend. Currently we only have one built in backend,
the current files based backend. These patches do not change any of the
behavior other than that we now call the methods through backend specific
wrapper functions rather than calling them directly.

At this stage we now have a defined set of methods needed for a refs
backend and we can start building and adding new types of ref backends
to git.

Very nice ;-).

I would have expected that refs.c would be the generic one and refs-be-*
would be the backend specific ones, though; that way you do not have to
introduce a new file refs-common.c at all, no?

On Wed, Aug 13, 2014 at 2:18 PM, Junio C Hamano [off-list ref] wrote:

Ronnie Sahlberg [off-list ref] writes:

quoted

15 of the patches, the refs-common.c patches, focuses on moving all backend
agnostic refs functions to a common file. This file will contain all
backend agnostic refs functions.

The last 6 patches adds a backend structure with the methods we need to
describe a pluggable backend. Currently we only have one built in backend,
the current files based backend. These patches do not change any of the
behavior other than that we now call the methods through backend specific
wrapper functions rather than calling them directly.

At this stage we now have a defined set of methods needed for a refs
backend and we can start building and adding new types of ref backends
to git.

Very nice ;-).

I would have expected that refs.c would be the generic one and refs-be-*
would be the backend specific ones, though; that way you do not have to
introduce a new file refs-common.c at all, no?

Makes sense.
Let me do those changes and then I will re-post sometime next week
once I get additional feedback on it.


regards
Ronnie Sahlberg