2 messages, 2 authors, 2016-06-15 · open the first message on its own page
From: Matthieu Moy <hidden>
Date: 2016-06-15 23:02:01
Tanay Abhra [off-list ref] writes:
I am attaching the v12 with two new functions git_configset_get_string() & git_configset_get_string_const().
Didn't you intend to change git_config_get_string to let it die in case of error instead of returning an error code? -- Matthieu Moy http://www-verimag.imag.fr/~moy/
From: Tanay Abhra <hidden>
Date: 2016-06-15 23:02:01
On 7/24/2014 9:09 PM, Matthieu Moy wrote:
Tanay Abhra [off-list ref] writes:quoted
I am attaching the v12 with two new functions git_configset_get_string() & git_configset_get_string_const().Didn't you intend to change git_config_get_string to let it die in case of error instead of returning an error code?
Yup, but it is the part of the new series not the old one. I sent this revised patch just for solving the constness debate. Also, I would need git_die_config() to print a proper error message which comes in the 7 part series not this one.