Re: [PATCH v2 1/3] completion: complete "unstuck" `git push --recurse-submodules`

John Keeping [off-list ref] writes:

Makes sense.  I don't think I noted the order in the "$cur" case, I just
put the new one in here so that they were sorted lexicographically.

Unless there is particular reason, consistently using lexicographic
order in all related places is one good way to organize things, but
doing so would involve flipping orders in the other case statement
for this particular patch.  In general, I prefer to see people add
new things at the end, when there is no particular reason to do
otherwise.

Do you want me to re-roll with this change or can you replace the patch
while applying?

I think I had to flip the third one to adjust to the change I
suggested to this; the result will be on 'pu', so please double
check when I push it out.

Thanks.

On Tue, Jul 22, 2014 at 02:17:13PM -0700, Junio C Hamano wrote:

John Keeping [off-list ref] writes:

quoted

Do you want me to re-roll with this change or can you replace the patch
while applying?

I think I had to flip the third one to adjust to the change I
suggested to this; the result will be on 'pu', so please double
check when I push it out.

The result on jk/more-push-completion looks good.  Thanks.