Re: [PATCH 3/5] Run the perf test suite for profile feedback too

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 3/5] Run the perf test suite for profile feedback too

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:01:50

Andi Kleen [off-list ref] writes:
From: Andi Kleen <redacted>

Open: If the perf test suite is representative enough it may
be reasonable to only run that and skip the much longer full
test suite. Thoughts?
I do not think it right now is representative, nor it was meant to
become so.  The operations are those that people cared about and
tuned, and hopefully it would cover stuff actual end users care
about in the real life, though.
quoted hunk
Signed-off-by: Andi Kleen <redacted>
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index a9770ac..ba64be9 100644
--- a/Makefile
+++ b/Makefile
@@ -1647,6 +1647,7 @@ ifeq ($(filter all,$(MAKECMDGOALS)),all)
 all:: profile-clean
 	$(MAKE) PROFILE=GEN all
 	$(MAKE) PROFILE=GEN -j1 test
+	$(MAKE) PROFILE=GEN -j1 perf
 endif
 endif

Re: [PATCH 3/5] Run the perf test suite for profile feedback too

From: Andi Kleen <hidden>
Date: 2016-06-15 23:01:50

On Mon, Jul 07, 2014 at 02:06:57PM -0700, Junio C Hamano wrote:
Andi Kleen [off-list ref] writes:
quoted
From: Andi Kleen <redacted>

Open: If the perf test suite is representative enough it may
be reasonable to only run that and skip the much longer full
test suite. Thoughts?
I do not think it right now is representative, nor it was meant to
become so.  The operations are those that people cared about and
tuned, and hopefully it would cover stuff actual end users care
about in the real life, though.
I ended up answering the question by creating two separate 
makefile targets in the next patch.

profile to run the full test suite and profile-fast to run
only the performance test. profile-fast as the name implies
is a lot faster to build, and fast enough that it's not 
annoying.

I'll remove the "Open"

-Andi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help