Re: move detection doesnt take filename into account

Robin Rosenberg [off-list ref] writes:

I think it does, but based on filename suffix. E.g. here is a rename of
three empty files with a suffix.

 3 files changed, 0 insertions(+), 0 deletions(-)
 rename 1.a => 2.a (100%)
 rename 1.b => 2.b (100%)
 rename 1.c => 2.c (100%)

This is not more than a chance.

We tie-break rename source candidates that have the same content
similarity score to a rename destination using "name similarity",
whose implementation has been diffcore-rename.c::basename_same(),
which scores 1 if `basename $src` and `basename $dst` are the same
and 0 otherwise, i.e. from 1.a to a/1.a is judged to be a better
rename than from 1.a to a/2.a but otherwise there is nothing that
favors rename from 1.a to 2.a over 1.a to 2.b.

thanks for the info!
then i suppose my bug is a petition to have name similarity instead use 
a different statistical matching algorithm.

On 07/01/2014 10:57 AM, Junio C Hamano wrote:

Robin Rosenberg [off-list ref] writes:

quoted

I think it does, but based on filename suffix. E.g. here is a rename of
three empty files with a suffix.

  3 files changed, 0 insertions(+), 0 deletions(-)
  rename 1.a => 2.a (100%)
  rename 1.b => 2.b (100%)
  rename 1.c => 2.c (100%)

This is not more than a chance.

We tie-break rename source candidates that have the same content
similarity score to a rename destination using "name similarity",
whose implementation has been diffcore-rename.c::basename_same(),
which scores 1 if `basename $src` and `basename $dst` are the same
and 0 otherwise, i.e. from 1.a to a/1.a is judged to be a better
rename than from 1.a to a/2.a but otherwise there is nothing that
favors rename from 1.a to 2.a over 1.a to 2.b.