Re: [PATCH] t9138-git-svn-authors-prog.sh fixups
From: Junio C Hamano <hidden>
Date: 2016-06-15 23:01:23
Jeremiah Mahler [off-list ref] writes:
quoted hunk
Several fixups of the t9138-git-svn-authors-prog.sh test script to follow current recommendations in t/README. - Fixed a Perl script with a full "#!/usr/bin/perl" shebang to use write_script() and $PERL_PATH as per t/README. - Placed svn-authors data setup inside a test_expect_success. - Fixed trailing quotes to use the same indentation throughout. Signed-off-by: Jeremiah Mahler <redacted> --- t/t9138-git-svn-authors-prog.sh | 35 +++++++++++++++++------------------ 1 file changed, 17 insertions(+), 18 deletions(-)diff --git a/t/t9138-git-svn-authors-prog.sh b/t/t9138-git-svn-authors-prog.sh index 83cc5fc..d54c37a 100755 --- a/t/t9138-git-svn-authors-prog.sh +++ b/t/t9138-git-svn-authors-prog.sh@@ -7,40 +7,39 @@ test_description='git svn authors prog tests' . ./lib-git-svn.sh -cat > svn-authors-prog <<'EOF' -#!/usr/bin/perl -$_ = shift; -if (s/-sub$//) { - print "$_ <$_\@sub.example.com>\n"; -} -else { - print "$_ <$_\@example.com>\n"; -} +write_script svn-authors-prog $PERL_PATH <<-\EOF
I think you meant to dq "$PERL_PATH" here. Other than that, looks OK to me. Thanks.