Re: [PATCH v1 04/25] contrib: remove 'buildsystems'

Felipe Contreras [off-list ref] writes:

Erik Faye-Lund wrote:

quoted

On Fri, May 9, 2014 at 10:14 AM, Felipe Contreras
[off-list ref] wrote:

quoted

If you want this script to remain in contrib, please:

 a) Write at least a few tests
 b) Write some documentation
 c) Explain why it cannot live outside the git.git repository like other
    tools. [1][2][3]

(Adding Marius, the original author to the CC-list)

Uh, why is such a burden required all of a sudden? contrib/README
mentions no such requirements, and the scripts have been accepted (and
maintained) since.

contrib/README mentions clearly the expectation that these scripts
eventually move to the core once they mature. This is never going to
happen for these.

It also mentions that inactive ones would be proposed for removal, and
this one is clearly inactive. It has 9 commits (if you count the one
that changes the execution bit).

quoted

Besides, you say "No activity since 2010" - this is not the case,
bc380fc is from November 2013.

You think changing the execution bit of a file is considered "activity"?

For an indication of "this software has actual users", it definitely
would count as such, yes.  Why would someone change the executable bit
if it did not impact his usage of the software?

The idea of removing software from distribution is to get rid of stuff
without a user base rather than punishing lazy developers.

If it were the latter, then you could argue that anybody not willing to
host his own repository should get thrown off Git's.  That would solve
the whole contrib "problem" in one fell swoop.

-- 
David Kastrup

David Kastrup wrote:

Felipe Contreras [off-list ref] writes:

quoted

quoted

Besides, you say "No activity since 2010" - this is not the case,
bc380fc is from November 2013.

You think changing the execution bit of a file is considered "activity"?

For an indication of "this software has actual users", it definitely
would count as such, yes.  Why would someone change the executable bit
if it did not impact his usage of the software?

Because that somebody spotted this while changing the executable bit of
other scripts, which is precisely what happened (or at least seems so
from the history).

The idea of removing software from distribution is to get rid of stuff
without a user base rather than punishing lazy developers.

No. There's tons of Git tools out there. Should we include them all in
contrib/?

-- 
Felipe Contreras