Thread (52 messages) 52 messages, 10 authors, 2016-06-15

Re: [PATCH v1 04/25] contrib: remove 'buildsystems'

From: Erik Faye-Lund <hidden>
Date: 2016-06-15 23:01:04

On Fri, May 9, 2014 at 10:14 AM, Felipe Contreras
[off-list ref] wrote:
Erik Faye-Lund wrote:
quoted
On Fri, May 9, 2014 at 2:58 AM, Felipe Contreras
[off-list ref] wrote:
quoted
No activity since 2010, no documentation, no tests.

Signed-off-by: Felipe Contreras <redacted>
---
 contrib/buildsystems/Generators.pm        |  42 --
 contrib/buildsystems/Generators/QMake.pm  | 189 ---------
 contrib/buildsystems/Generators/Vcproj.pm | 626 ------------------------------
 contrib/buildsystems/engine.pl            | 359 -----------------
 contrib/buildsystems/generate             |  29 --
 contrib/buildsystems/parse.pl             | 228 -----------
 6 files changed, 1473 deletions(-)
 delete mode 100644 contrib/buildsystems/Generators.pm
 delete mode 100644 contrib/buildsystems/Generators/QMake.pm
 delete mode 100644 contrib/buildsystems/Generators/Vcproj.pm
 delete mode 100755 contrib/buildsystems/engine.pl
 delete mode 100755 contrib/buildsystems/generate
 delete mode 100755 contrib/buildsystems/parse.pl
Please don't. This script is useful to build with the MSVC IDE, which
enables us to use their excellent debugger.
If you want this script to remain in contrib, please:

 a) Write at least a few tests
 b) Write some documentation
 c) Explain why it cannot live outside the git.git repository like other
    tools. [1][2][3]
(Adding Marius, the original author to the CC-list)

Uh, why is such a burden required all of a sudden? contrib/README
mentions no such requirements, and the scripts have been accepted (and
maintained) since. Besides, you say "No activity since 2010" - this is
not the case, bc380fc is from November 2013. And there's already
*some* documentation in the scripts themselves.

Please stop your pointless crusade that'll only break other people's work-flows.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help