Re: [RTC/PATCH] Add 'update-branch' hook

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [RTC/PATCH] Add 'update-branch' hook

From: Stephen Leake <hidden>
Date: 2016-06-15 23:00:47

Felipe Contreras [off-list ref] writes:
Stephen Leake wrote:
quoted
Felipe Contreras [off-list ref] writes:
quoted
Ilya Bobyr wrote:
quoted
On 4/21/2014 2:17 PM, Felipe Contreras wrote:
quoted
Ilya Bobyr wrote:
quoted
Also, most have names that start with either "pre-" or "post-".
It seems reasonable for both "pre-update-branch" and
"post-update-branch" to exist.
I don't see what would be the point in that.
Do you see the point in the other hooks doing that?
Yes, there a reason for the existance of those hooks. Now tell me why would
anybody use post-update-branch instead of pre-update-branch?
I have a branch which should always be recompiled on update;
post-update-branch would be a good place for that.
And why would pre-update-branch not serve that purpose?
Because the code that needs to be compiled is not yet in the workspace

-- 
-- Stephe

Re: [RTC/PATCH] Add 'update-branch' hook

From: Felipe Contreras <hidden>
Date: 2016-06-15 23:00:47

Stephen Leake wrote:
Felipe Contreras [off-list ref] writes:
quoted
Stephen Leake wrote:
quoted
Felipe Contreras [off-list ref] writes:
quoted
Ilya Bobyr wrote:
quoted
On 4/21/2014 2:17 PM, Felipe Contreras wrote:
quoted
Ilya Bobyr wrote:
quoted
Also, most have names that start with either "pre-" or "post-".
It seems reasonable for both "pre-update-branch" and
"post-update-branch" to exist.
I don't see what would be the point in that.
Do you see the point in the other hooks doing that?
Yes, there a reason for the existance of those hooks. Now tell me why would
anybody use post-update-branch instead of pre-update-branch?
I have a branch which should always be recompiled on update;
post-update-branch would be a good place for that.
And why would pre-update-branch not serve that purpose?
Because the code that needs to be compiled is not yet in the workspace
And it won't be in 'post-update-branch' either.

 % git checkout master
 % git branch feature-a stable
 <- update-branch hook will be called here

The hook will get 'feature-a' as the first argument, but the code in the
workspace would correspond to 'master'; the checked out branch (pre or post).

-- 
Felipe Contreras
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help