DORMANTno replies

[PATCH v5] branch.c: change install_branch_config() to use skip_prefix()

From: Guanglin Xu <hidden>
Date: 2016-06-15 23:00:09
Subsystem: the rest · Maintainer: Linus Torvalds

to avoid a magic code of 11.

Helped-by: Sun He [off-list ref]
Helped-by: Eric Sunshine [off-list ref]
Helped-by: Jacopo Notarstefano [off-list ref]

Signed-off-by: Guanglin Xu <redacted>
---

This is an implementation of the idea#2 of GSoC 2014 microproject.

 branch.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/branch.c b/branch.c
index 723a36b..fae7715 100644
--- a/branch.c
+++ b/branch.c
@@ -49,8 +49,8 @@ static int should_setup_rebase(const char *origin)
 
 void install_branch_config(int flag, const char *local, const char *origin, const char *remote)
 {
-	const char *shortname = remote + 11;
-	int remote_is_branch = starts_with(remote, "refs/heads/");
+	const char *shortname = skip_prefix(remote ,"refs/heads/");
+	int remote_is_branch = !!shortname;
 	struct strbuf key = STRBUF_INIT;
 	int rebasing = should_setup_rebase(origin);
 
-- 
1.9.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help