Re: [PATCH] rev-parse: fix --resolve-git-dir argument handling

Junio C Hamano [off-list ref] writes:

John Keeping [off-list ref] writes:

quoted

There are two problems here:

1) If no argument is provided, then the command segfaults
2) The argument is not consumed, so there will be excess output

Fix both of these in one go by restructuring the handler for this
option.

Reported-by: Daniel Hahler <redacted>
Signed-off-by: John Keeping <redacted>
---

Looks sensible; thanks.

Ehh, I spoke too fast. Don't we already have this queued as a43219f2
(rev-parse: check i before using argv[i] against argc, 2014-01-28)?

On Tue, Feb 18, 2014 at 04:25:37PM -0800, Junio C Hamano wrote:

Junio C Hamano [off-list ref] writes:

quoted

John Keeping [off-list ref] writes:

quoted

There are two problems here:

1) If no argument is provided, then the command segfaults
2) The argument is not consumed, so there will be excess output

Fix both of these in one go by restructuring the handler for this
option.

Reported-by: Daniel Hahler <redacted>
Signed-off-by: John Keeping <redacted>
---

Looks sensible; thanks.

Ehh, I spoke too fast. Don't we already have this queued as a43219f2
(rev-parse: check i before using argv[i] against argc, 2014-01-28)?

Yes, and it catches more cases than mine.  I only checked against master
and had missed that when it went past on the list.