Francesco Pretto [off-list ref] writes:
According to "Documentation/gitmodules.txt", 'checkout' is a valid
'submodule.<name>.update' command.
As you can see in the surrounding text, we call the value of
submodule.*.update a "mode", not a command.
Also "git-submodule.sh" refers to
it and processes it correctly.
This present tense puzzles me. If it already refers to checkout and
handles it correctly is there anything that needs to be done? Or
did you mean "it should refer to and process it but it doesn't, so
make it so?"
Reflecting commit 'ac1fbb' to support
this syntax and also validate property values during 'update' command,
issuing an error if the value found is unknown.
Sorry, but -ECANNOTPARSE.
2014/1/7 Junio C Hamano [off-list ref]:
Francesco Pretto [off-list ref] writes:
quoted
According to "Documentation/gitmodules.txt", 'checkout' is a valid
'submodule.<name>.update' command.
As you can see in the surrounding text, we call the value of
submodule.*.update a "mode", not a command.
Ok.
quoted
Also "git-submodule.sh" refers to
it and processes it correctly.
This present tense puzzles me. If it already refers to checkout and
handles it correctly is there anything that needs to be done? Or
did you mean "it should refer to and process it but it doesn't, so
make it so?"
Like you said, "it already refers to checkout and handles it
correctly". I think the use of the simple present tense here is
correct: it's a fact. Feel free to advice another wording if you
prefer.
quoted
Reflecting commit 'ac1fbb' to support
this syntax and also validate property values during 'update' command,
issuing an error if the value found is unknown.
Sorry, but -ECANNOTPARSE.
Not sure what's wrong here, can you explain why it's failing? I'm
using git-format-patch/git-send-email with default settings. Also, if
you can edit and keep the sign-off (I'm not familiar with the
mailing-list maintainer workflow, sorry), feel free to do it.
Thanks
2014/1/7 Junio C Hamano [off-list ref]:
Sorry, but -ECANNOTPARSE.
A bird told me what -ECANNOTPARSE means. Tell me if this comment sounds better:
According to "Documentation/gitmodules.txt", 'checkout' is a valid
'submodule.<name>.update' mode. Also "git-submodule.sh" already refers
to it and handles it correctly. Fix cmd_init() to also accept 'checkout' as
valid update mode and add a similar validation in cmd_update(), issuing
an error if the value read is unknown.