Re: [PATCH 9/9] trailer: add tests for "git interpret-trailers"

Christian Couder [off-list ref] writes:

+# Do not remove trailing spaces below!
+cat >complex_message_trailers <<'EOF'
+Fixes: 
+Acked-by: 
+Reviewed-by: 
+Signed-off-by: 
+EOF

Just a hint.  I think it is far safer and robust over time to do
something like this:

	sed -e 's/ Z$/ /' <<-\EOF
        Fixes: Z
        Acked-by: Z
        EOF

instead of a comment, which can warn human developers but does not
do anything to prevent their editors' auto-fix features from kicking
in.

On Mon, Dec 30, 2013 at 09:19:55AM -0800, Junio C Hamano wrote:

Christian Couder [off-list ref] writes:

quoted

+# Do not remove trailing spaces below!
+cat >complex_message_trailers <<'EOF'
+Fixes: 
+Acked-by: 
+Reviewed-by: 
+Signed-off-by: 
+EOF

Just a hint.  I think it is far safer and robust over time to do
something like this:

	sed -e 's/ Z$/ /' <<-\EOF
        Fixes: Z
        Acked-by: Z
        EOF

instead of a comment, which can warn human developers but does not
do anything to prevent their editors' auto-fix features from kicking
in.

This, but for simplicity, since every line needs the trailing space, why
not just use 's/$/ /' and drop the ' Z' on every line?

</bikeshed>

- Josh Triplett