Re: [PATCH v3 19/21] t: add basic bitmap functionality tests

Jeff King [off-list ref] writes:

Now that we can read and write bitmaps, we can exercise them
with some basic functionality tests. These tests aren't
particularly useful for seeing the benefit, as the test
repo is too small for it to make a difference. However, we
can at least check that using bitmaps does not break anything.

Signed-off-by: Jeff King <redacted>

Reviewed-by: Thomas Rast <redacted>

One nit:

The name suggests a bare repo, but it is a full clone.  Not that it
matters.

-- 
Thomas Rast
tr@thomasrast.ch

On Sat, Dec 07, 2013 at 05:43:29PM +0100, Thomas Rast wrote:

One nit:

quoted

+test_expect_success JGIT 'jgit can read our bitmaps' '
+	git clone . compat-us.git &&
+	(
+		cd compat-us.git &&

The name suggests a bare repo, but it is a full clone.  Not that it
matters.

It was originally supposed to be a bare repo, but I had trouble
convincing jgit to actually run in a bare repo. The solution was to
switch to a non-bare one. :)

But obviously I forgot to update the name. I agree it's better to use a
more obvious name. Fixed.

-Peff