Re: 1.8.4 rebase regression?

Patrick Welche [off-list ref] writes:

Got it: the change between 1.8.3.4 and 1.8.4 is that colour is on by
default. If I take 1.8.3.4 and git -c color.ui=always log, I see
the same ESC codes => not a regression! I'll just have to sort my
box out if I want colour. (The only oddity is that git status is
correctly colourful.)

Maybe you disabled the pager for "git status"?

(

quoted

If you have a bit of time, you can use "git bisect" on a clone of
git.git to find out the guilty commit.

commit e5be297279e8ee8c503eb59da21ab17edc40e748
Merge: a3bc3d0 6897a64

but that is presumably just when the default changed
)

It doesn't seem so.

On my box, color work just fine when piped to less, but I guess not all
pagers accept this, and perhaps a wrong value of $LESS can cause less to
reject it.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

On Tue, Sep 17, 2013 at 11:23:51AM +0200, Matthieu Moy wrote:

Patrick Welche [off-list ref] writes:

quoted

Got it: the change between 1.8.3.4 and 1.8.4 is that colour is on by
default. If I take 1.8.3.4 and git -c color.ui=always log, I see
the same ESC codes => not a regression! I'll just have to sort my
box out if I want colour. (The only oddity is that git status is
correctly colourful.)

Maybe you disabled the pager for "git status"?

Interesting: I didn't disable it on purpose, but indeed, it is not
used for status.

Can't believe this:

$ echo $PAGER
more

unset PAGER, and git diff is fine...

Thanks for all the help!

Cheers,

Patrick