Re: [RFC] Disabling status hints in COMMIT_EDITMSG

4 messages, 3 authors, 2016-06-15 · open the first message on its own page

Re: [RFC] Disabling status hints in COMMIT_EDITMSG

From: Matthieu Moy <hidden>
Date: 2016-06-15 22:58:43

Junio C Hamano [off-list ref] writes:
But at the same time, I feel that these redundant lines, especially
the latter one, would give the users a stronger cue than just saying
that "bar is Untracked"; "do X to include" reminds that bar will not
be included if nothing is done.
The one which draw my attention was "(use "git commit" to conclude
merge)" which is particularly counter-productive when you are already
doing a "git commit". The advice for untracked files is less
counter-productive, but while we're removing the non-sensical ones, I
think it makes sense to remove the essentially-useless ones too.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

Re: [RFC] Disabling status hints in COMMIT_EDITMSG

From: Javier Domingo <hidden>
Date: 2016-06-15 22:58:43

IMHO, It is alright as it is.

I have been using git for 4~ years now, and I still find very useful
those lines. They are like a git status while committing, and it's the
key to avoid accidental commits of objects or forgetting files in a
commit. Between that and that the commit message can't be empty, I can
abort a commit and correct the staging area.

Cheers,

Javier Domingo

Re: [RFC] Disabling status hints in COMMIT_EDITMSG

From: John Szakmeister <hidden>
Date: 2016-06-15 22:58:43

On Wed, Sep 11, 2013 at 3:24 AM, Matthieu Moy
[off-list ref] wrote:
Junio C Hamano [off-list ref] writes:
quoted
But at the same time, I feel that these redundant lines, especially
the latter one, would give the users a stronger cue than just saying
that "bar is Untracked"; "do X to include" reminds that bar will not
be included if nothing is done.
The one which draw my attention was "(use "git commit" to conclude
merge)" which is particularly counter-productive when you are already
doing a "git commit". The advice for untracked files is less
counter-productive, but while we're removing the non-sensical ones, I
think it makes sense to remove the essentially-useless ones too.
FWIW, I think it makes sense to remove the extra advice too.

-John

Re: [RFC] Disabling status hints in COMMIT_EDITMSG

From: Javier Domingo <hidden>
Date: 2016-06-15 22:58:43

That extra info doesn't occupy too much, and helps distinguish between
sections. They do also remember you the commands to use (thought after
some time using git, you may not need it).

Cheers,

Javier
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help