For custom builds of Git it sometimes is inconvenient to annotate tags
because there simply is nothing to say, so do not require an annotation.
Signed-off-by: Sebastian Schuberth <redacted>
---
GIT-VERSION-GEN | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
index b444c18..68b61e3 100755
--- a/GIT-VERSION-GEN
+++ b/GIT-VERSION-GEN
@@ -12,7 +12,7 @@ if test -f version
then
VN=$(cat version) || VN="$DEF_VER"
elif test -d ${GIT_DIR:-.git} -o -f .git &&
- VN=$(git describe --match "v[0-9]*" --abbrev=7 HEAD 2>/dev/null) &&
+ VN=$(git describe --tags --match "v[0-9]*" --abbrev=7 HEAD 2>/dev/null) &&
case "$VN" in
*$LF*) (exit 1) ;;
v[0-9]*)--
1.8.3.msysgit.1.3.g5b82b42.dirty
On Sep 6, 2013, at 13:10, Sebastian Schuberth wrote:
For custom builds of Git it sometimes is inconvenient to annotate tags
because there simply is nothing to say, so do not require an
annotation.
It's not that hard to add -m "" to the command line:
git tag -a -m "" new-annotated-tag
if you're just trying to avoid the editor or thinking up a message.
Is `-m ""` really that inconvenient?
On Sat, Sep 7, 2013 at 12:34 AM, Kyle J. McKay [off-list ref] wrote:
quoted
For custom builds of Git it sometimes is inconvenient to annotate tags
because there simply is nothing to say, so do not require an annotation.
It's not that hard to add -m "" to the command line:
It's not hard to type those characters, but (for me) it's hard to
remember that I have to do it.
if you're just trying to avoid the editor or thinking up a message. Is `-m
""` really that inconvenient?
Yes, to me it's inconvenient, but not that much. And I think passing
an empty annotation like you suggest is even worse than not setting an
annotation at all, because I would assume if an annotation is set it's
not empty, and if it is, I would expect this to be a user error.
--
Sebastian Schuberth