DORMANTno replies

[PATCH] builtin/fetch.c: Fix a sparse warning

From: Ramsay Jones <hidden>
Date: 2016-06-15 22:58:32
Subsystem: the rest · Maintainer: Linus Torvalds

Sparse issues an "'prepare_transport' was not declared. Should it
be static?" warning. In order to suppress the warning, since this
symbol only requires file scope, we simply add the static modifier
to it's declaration.

Signed-off-by: Ramsay Jones <redacted>
---

Hi Junio,

When you re-build the next branch, could you please squash this into
commit db5723c6 ("fetch: refactor code that prepares a transport",
07-08-2013). [from the 'jc/transport-do-not-use-connect-twice-in-fetch'
branch]

Thanks!

ATB,
Ramsay Jones


 builtin/fetch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/fetch.c b/builtin/fetch.c
index e880116..9e654ef 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -747,7 +747,7 @@ static void set_option(struct transport *transport, const char *name, const char
 			name, transport->url);
 }
 
-struct transport *prepare_transport(struct remote *remote)
+static struct transport *prepare_transport(struct remote *remote)
 {
 	struct transport *transport;
 	transport = transport_get(remote, NULL);
-- 
1.8.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help