Re: [PATCH v4 2/4] gitweb: vertically centre contents of page footer

Tony Finch [off-list ref] writes:

Hmmm, is it a good idea to do "px" here, or are they ways to do
relative to x-height or something to make sure the text fits?

Junio C Hamano [off-list ref] wrote:

Tony Finch [off-list ref] writes:

quoted

 div.page_footer {
-	height: 17px;
+	height: 22px;
 	padding: 4px 8px;
 	background-color: #d9d8d1;
 }

 div.page_footer_text {
+	line-height: 22px;
 	float: left;
 	color: #555555;
 	font-style: italic;

Hmmm, is it a good idea to do "px" here, or are they ways to do
relative to x-height or something to make sure the text fits?

Good question. I also don't know much about css. I basically followed the
style that was already there, and found out about vertical centering using
line-height by searching the web.

I think font-size relative scaling would require a bigger overhaul.

Tony.
-- 
f.anthony.n.finch  [off-list ref]  http://dotat.at/
Forties, Cromarty: East, veering southeast, 4 or 5, occasionally 6 at first.
Rough, becoming slight or moderate. Showers, rain at first. Moderate or good,
occasionally poor at first.