Re: [PATCH v2] remotes-hg: bugfix for fetching non local remotes
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:58:15
Joern Hees [off-list ref] writes:
6796d49 introduced a bug by making shared_path == ".git/hg' which will most likely exist already, causing a new remote never to be cloned and subsequently causing hg.share to fail with error msg: "mercurial.error.RepoError: repository .git/hg not found" Changing shared_path to ".git/hg/.shared" will solve this problem
Here you say "shared" and the code says "share"; which one is preferred (I know either would work, but we would want to be consistent). I'd vote for "shared", but I do not see a compelling reason to pick one over the other so...?
quoted hunk
and create a shared local mercurial repository for non local remotes. The initial dot circumvents a name clash problem should a remote be called "shared". Signed-off-by: Joern Hees <redacted> Mentored-by: Antoine Pelisse [off-list ref] --- contrib/remote-helpers/git-remote-hg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg index 0194c67..4a7d7a8 100755 --- a/contrib/remote-helpers/git-remote-hg +++ b/contrib/remote-helpers/git-remote-hg@@ -390,7 +390,7 @@ def get_repo(url, alias): if not os.path.exists(dirname): os.makedirs(dirname) else: - shared_path = os.path.join(gitdir, 'hg') + shared_path = os.path.join(gitdir, 'hg', '.share') if not os.path.exists(shared_path): try: hg.clone(myui, {}, url, shared_path, update=False, pull=True)