[PATCH] Use compat/regex on Cygwin

Cygwin's regex library does not pass git's tests, so don't use it. This
fixes failures in t4018 and t4034.

Signed-off-by: Mark Levedahl <redacted>
---
 config.mak.uname | 1 +
 1 file changed, 1 insertion(+)

diff --git a/config.mak.uname b/config.mak.uname
index 7ac541e..6901597 100644
--- a/config.mak.uname
+++ b/config.mak.uname

@@ -165,6 +165,7 @@ ifeq ($(uname_O),Cygwin)
 	NO_FAST_WORKING_DIRECTORY = UnfortunatelyYes
 	NO_TRUSTABLE_FILEMODE = UnfortunatelyYes
 	NO_ST_BLOCKS_IN_STRUCT_STAT = YesPlease
+	NO_REGEX = UnfortunatelyYes
 	# There are conflicting reports about this.
 	# On some boxes NO_MMAP is needed, and not so elsewhere.
 	# Try commenting this out if you suspect MMAP is more efficient

-- 
1.8.3.2.0.13

Mark Levedahl wrote:

Cygwin's regex library does not pass git's tests, so don't use it. This
fixes failures in t4018 and t4034.

Hmm, these tests have always passed for me on cygwin. So, this is
presumably a regression in the new-lib regex library versions used
by cygwin 1.5 and cygwin 1.7.

ATB,
Ramsay Jones

On 07/16/2013 05:41 PM, Ramsay Jones wrote:

Mark Levedahl wrote:

quoted

Cygwin's regex library does not pass git's tests, so don't use it. This
fixes failures in t4018 and t4034.

Hmm, these tests have always passed for me on cygwin. So, this is
presumably a regression in the new-lib regex library versions used
by cygwin 1.5 and cygwin 1.7.

ATB,
Ramsay Jones

Perhaps we should just completely separate cygwin 1.5 settings from 
those for current cygwin. Extra motivation is that cygwin 1.5 is no 
longer on the mirrors - the last real update was mid 2009, and the 
project finally removed the installation tree altogether.

Mark

On 07/16/2013 05:41 PM, Ramsay Jones wrote:

Mark Levedahl wrote:

quoted

Cygwin's regex library does not pass git's tests, so don't use it. This
fixes failures in t4018 and t4034.

Hmm, these tests have always passed for me on cygwin. So, this is
presumably a regression in the new-lib regex library versions used
by cygwin 1.5 and cygwin 1.7.

ATB,
Ramsay Jones

Yes, cygwin 1.7 now uses the newlib regex functions, and those are not 
quite up to snuff. Another case for calling 1.5 a separate platform 
altogether.

Mark