Re: [PATCH] prompt: do not double-discriminate detached HEAD

3 messages, 3 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] prompt: do not double-discriminate detached HEAD

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:58:01

John Szakmeister [off-list ref] writes:
On Sun, Jul 7, 2013 at 8:52 AM, Ramkumar Ramachandra [off-list ref] wrote:
quoted
When GIT_PS1_SHOWCOLORHINTS is turned on, there is no need to put a
detached HEAD within parenthesis: the color can be used to discriminate
the detached HEAD.

Signed-off-by: Ramkumar Ramachandra <redacted>
---
 For cuteness :)
Personally, I'd rather see the parens kept.  Not everyone sees red
very well--I know several people who can't see it at all, and it keeps
it consistent with non-colored output.
+1; I find red on many terminal emulators to be too dark to tell,
especially in a small font, from black myself.

Re: [PATCH] prompt: do not double-discriminate detached HEAD

From: Kyle McKay <hidden>
Date: 2016-06-15 22:58:01

On Jul 7, 2013, at 10:53, Junio C Hamano wrote:
John Szakmeister [off-list ref] writes:
quoted
On Sun, Jul 7, 2013 at 8:52 AM, Ramkumar Ramachandra <artagnon@gmail.com 
quoted
wrote:
When GIT_PS1_SHOWCOLORHINTS is turned on, there is no need to put a
detached HEAD within parenthesis: the color can be used to  
discriminate
the detached HEAD.

Signed-off-by: Ramkumar Ramachandra <redacted>
---
For cuteness :)
Personally, I'd rather see the parens kept.  Not everyone sees red
very well--I know several people who can't see it at all, and it  
keeps
it consistent with non-colored output.
+1; I find red on many terminal emulators to be too dark to tell,
especially in a small font, from black myself.
+1; me too for the same reason.

Re: [PATCH] prompt: do not double-discriminate detached HEAD

From: Ramkumar Ramachandra <hidden>
Date: 2016-06-15 22:58:02

Junio C Hamano wrote:
+1; I find red on many terminal emulators to be too dark to tell,
especially in a small font, from black myself.
It's a matter of taste anyway.  I hope everyone's not going colorblind
from writing too much C89 and Bourne shell ;)

Eduardo R. D'Avila wrote:
I think color in terminals should be used to highlight and make it easier to see
textual information, not to replace them. So I would keep the parenthesis.
I largely agree, but there are a few exceptions.  Most notably, have
you noticed how, in addition to font-locking, scheme-mode replaces
lambda with λ?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help