Re: [PATCH v2 2/2] send-email: introduce sendemail.smtpsslcertpath

John Keeping [off-list ref] writes:

I do not see any "use IO::Socket::SSL" anywhere after applying this
patch.  Is this expected to work?

On Sat, Jul 06, 2013 at 09:12:31PM -0700, Junio C Hamano wrote:

John Keeping [off-list ref] writes:

quoted

@@ -1096,19 +1101,18 @@ sub smtp_auth_maybe {
 # Helper to come up with SSL/TLS certification validation params
 # and warn when doing no verification
 sub ssl_verify_params {
-	use IO::Socket::SSL qw(SSL_VERIFY_PEER SSL_VERIFY_NONE);
-
-	if (!defined $smtp_ssl_cert_path) {
-		$smtp_ssl_cert_path = "/etc/ssl/certs";
+	if ($smtp_ssl_verify == 0) {
+		return (SSL_verify_mode => IO::Socket::SSL->SSL_VERIFY_NONE);

I do not see any "use IO::Socket::SSL" anywhere after applying this
patch.  Is this expected to work?

I don't get any errors about unknown variables when running it.  Do we
get IO::Socket::SSL imported through Net::SMTP::SSL, which extends it?