Re: [PATCH v5] [submodule] Add --depth to submodule update/add

Jens Lehmann [off-list ref] writes:

Am 02.07.2013 23:42, schrieb Fredrik Gustafsson:

quoted

Add the --depth option to the add and update commands of "git submodule",
which is then passed on to the clone command. This is useful when the
submodule(s) are huge and you're not really interested in anything but
the latest commit.

Tests are added and some indention adjustments were made to conform to the
rest of the testfile on "submodule update can handle symbolic links in pwd".

Signed-off-by: Fredrik Gustafsson <redacted>
---

And I finally thought I'd everything right. I appriciate your reviews.

I left the "" on $5 for consistency as suggested.

Thanks, looking good to me. Passes all tests and the new tests fail
when the change in the submodule script is reverted.

Acked-by: Jens Lehmann <redacted>

The only minor problem is that this patch still does not apply cleanly
to master, next or pu (I wonder what you based this on ;-).

Thanks; will replace what I queued on 'pu'.

On Wed, Jul 03, 2013 at 01:13:12AM -0700, Junio C Hamano wrote:

Jens Lehmann [off-list ref] writes:

quoted

The only minor problem is that this patch still does not apply cleanly
to master, next or pu (I wonder what you based this on ;-).

Thanks; will replace what I queued on 'pu'.

I based it on master, but have forgott to rebase since v2. This is based
on 3e7a5b489e45ae8a3a0b222893d58b172d883136.

The merge conflict is pretty clean, would you (Junio) stil like a
rebased update of this patch?

-- 
Med vänliga hälsningar
Fredrik Gustafsson

tel: 0733-608274
e-post: iveqy@iveqy.com