Re: contrib/mw-to-git/Git/Mediawiki.pm

Matthieu Moy [off-list ref] writes:

Benoît Person [off-list ref] writes:

quoted

Junio, Matthieu : should I resend a new version of my serie which
renames the 'git' (lowercase) file into something like 'git-dev' ?

I'd call it bin-wrapper/git, so that people can put bin-wrapper/ in
their $PATH if needed, and by analogy with ../../bin-wrapper. If you go
this way, don't forget to update the $0 relative paths.

git-dev is OK with me too.

quoted

(some comments directly mentionning the 'git' (lowercase) file needs
to be updated as well in the Makefile)

Yes.

I just noticed that the script is not strictly a text file, ending
with an incomplete line, by the way.

Hmph.  Does it even need to be in-tree then?  Is it insufficient to
run ../../git from that directory instead?

Well, the fact is we use Perl packages now (Git.pm and
Git::Mediawiki.pm in contrib/mw-to-git/Git/). The way we build perl
scripts in the toplevel's Makefile makes those packages accessible
only in $GITPERLLIB if it's defined and defaults to $INSTLIBDIR to
seek for installed version of those packages.

We use a bin-wrapper to define that $GITPERLLIB variable so that the
installed version gets bypassed by the one presents in the directory
defined in $GITPERLLIB.

I just noticed that the script is not strictly a text file, ending
with an incomplete line, by the way.

an incomplete line ?