Re: [PATCH] status: display the SHA1 of the commit being currently processed

Johannes Sixt [off-list ref] writes:

Am 6/17/2013 15:57, schrieb Mathieu Liénard--Mayor:

quoted

Le 2013-06-17 15:54, Peter Krefting a écrit :

quoted

Mathieu Liénard--Mayor:

quoted

Actually, at first I dealt with it this way:

status_printf_ln(s, color,
                _("Splitting %s while rebasing branch '%s' on '%s'."),
         stopped_sha ? stopped_sha : _("a commit"),
         ....);

Would this be more suitable for translators ?

Not really, the text surrounding "a commit" might need to be
inflected differently depending on whether it is a SHA-1 or the "a
commit" string. Word order might also be different.

Okay, I'll use what you suggested then.

That's not a good idea. Do we already use "%1$" style formats elsewhere?

In the template, we obviously don't.

But my understanding is that the reordering using printf() is the
mechanism we suggest l10n folks to use when the order of parameters
given to printf does not match the preferred word order in the
message in their language.

Junio C Hamano:

But my understanding is that the reordering using printf() is the 
mechanism we suggest l10n folks to use when the order of parameters 
given to printf does not match the preferred word order in the 
message in their language.

It's documented in the gettext manual, and seems to be used in the 
zh_CN.po to change the word order in quite a few places.

-- 
\\// Peter - http://www.softwolves.pp.se/

Am 6/20/2013 9:56, schrieb Peter Krefting:

Junio C Hamano:

quoted

But my understanding is that the reordering using printf() is the
mechanism we suggest l10n folks to use when the order of parameters
given to printf does not match the preferred word order in the message
in their language.

It's documented in the gettext manual, and seems to be used in the
zh_CN.po to change the word order in quite a few places.

It is fine to use %n$ in translated strings as long as gettext is enabled
only on systems that have a sufficiently capable printf and these formats
are not used in the source code.

But you can't have this string:

  "Splitting a commit while rebasing branch '%2$s' on '%3$s'."

neither in the template nor in the translation, because the numbers must
begin at 1 (and must be used without gaps).

-- Hannes