Re: [PATCH v2 0/5] Write a good 'git stash store' for autostash

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH v2 0/5] Write a good 'git stash store' for autostash

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:45

Ramkumar Ramachandra [off-list ref] writes:
So, I've taken Junio's suggestion and designed a proper command-line
interface for 'git stash store' in this iteration:

  git stash store [-m <message>] [-e <error>] <commit>
I am perplexed; that would not something I _would_ design or
suggest.  The "-e <error>" looks especially odd, in that "-e"
usually refers to something the command evaluates (e.g. sed, perl),
but more importantly if the caller wants a custom error message,
normal programmers would do

	command || die "my custom error message"

and if "command" wants to show its own error by default, perhaps do

	command --quiet || die "my custom error message"

Re: [PATCH v2 0/5] Write a good 'git stash store' for autostash

From: Ramkumar Ramachandra <hidden>
Date: 2016-06-15 22:57:45

Junio C Hamano wrote:
quoted
  git stash store [-m <message>] [-e <error>] <commit>
I am perplexed; that would not something I _would_ design or
suggest.  The "-e <error>" looks especially odd, in that "-e"
usually refers to something the command evaluates (e.g. sed, perl),
but more importantly if the caller wants a custom error message,
normal programmers would do

        command || die "my custom error message"
Another result of me taking your suggestion too literally [1], and not
using my brains :/

[1]: http://article.gmane.org/gmane.comp.version-control.git/224174
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help