Re: [PATCH 1/2] submodule: handle multibyte characters in name

Jens Lehmann [off-list ref] writes:

Hmm, I just came around to test that patch, and for me the new
test even succeeds without the changes to module_list(). So I'm
not convinced yet what we are fixing here ;-)

My guess is that you have core.quotepaths set to false.

The original poster reported that the submodule just added locally
is not showing up in a subsequent `git submodule`. And it doesn't
for me either, no matter if the path contains umlauts or not. Will
take a deeper look when I find some more time to do that, maybe
recent changes to "git add" play a role here too.

Thanks.

On Wed, Jun 12, 2013 at 03:57:52PM -0700, Junio C Hamano wrote:

Jens Lehmann [off-list ref] writes:

quoted

Hmm, I just came around to test that patch, and for me the new
test even succeeds without the changes to module_list(). So I'm
not convinced yet what we are fixing here ;-)

My guess is that you have core.quotepaths set to false.

Actually the bug-reporter claimed to see the submodule in .gitmodules
but not when listed with git submodule.

The test is missing one line in the end to check for this. Sorry about
that.

I've a new iteration ready for this but want to test it a bit more
locally so I don't miss anything else first.

-- 
Med vänliga hälsningar
Fredrik Gustafsson

tel: 0733-608274
e-post: iveqy@iveqy.com