Re: [PATCH] credential-osxkeychain: support more protocols

On Mon, May 27, 2013 at 9:55 AM, Xidorn Quan [off-list ref] wrote:
[snip]

I thought that SSH password logins can benefit from it, but I just
found that it is wrong because it seems that SSH client is responsible
for authenticating. Consequently, supporting SSH here is useless.
I will remove that lines and send this patch again.

Since it is the first time I submit a patch to git, I am not very
familiar with the convention here. Should I send the modified patch
to the maintainer directly? And what information should I append to
my patch before it can get merged?

You'll need to read Documentation/SubmittingPatches (here's a link to
a version online:
https://github.com/git/git/blob/master/Documentation/SubmittingPatches).

You should resend this patch with the fix and change "[PATCH]" to
"[PATCH v2]", so the folks involved know that this is the second
iteration.  You also need to include a "Signed-off-by" line in your
patch, which means you agree to the agreement set forth in the
"Developer's Certificate of Origin" (which is in the SubmittingPatches
documentation).  You can easily include this line when you make the
commit by using the `-s` option on `git commit`.

You can also add an "Acked-by" line for me (since I reviewed and
approve of the change):

    Acked-by: John Szakmeister [off-list ref]

HTH!

-John

On Mon, May 27, 2013 at 10:28 PM, John Szakmeister [off-list ref] wrote:
[snip]

You'll need to read Documentation/SubmittingPatches (here's a link to
a version online:
https://github.com/git/git/blob/master/Documentation/SubmittingPatches).

You should resend this patch with the fix and change "[PATCH]" to
"[PATCH v2]", so the folks involved know that this is the second
iteration.  You also need to include a "Signed-off-by" line in your
patch, which means you agree to the agreement set forth in the
"Developer's Certificate of Origin" (which is in the SubmittingPatches
documentation).  You can easily include this line when you make the
commit by using the `-s` option on `git commit`.

You can also add an "Acked-by" line for me (since I reviewed and
approve of the change):

    Acked-by: John Szakmeister [off-list ref]

HTH!

Thx for your explaining, it helps a lot!

After reading the doc, I have a question that when can I affirm that
the list reaches a consensus?

--
Xidorn Quan