Re: [PATCH] Document push --no-verify

Junio C Hamano [off-list ref] writes:

Thomas Rast [off-list ref] writes:

quoted

ec55559 (push: Add support for pre-push hooks, 2013-01-13) forgot to
add a note to git-push(1) about the new --no-verify option.

Does it take --verify option (that may well be the default) so that
somebody with

         [alias] put = push --no-verify

can say "git put --verify args..."?

Yes.  Doesn't parse-options implicitly do the correct negation for all
boolean options, even those that are declared in their negative form?

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

ec55559 (push: Add support for pre-push hooks, 2013-01-13) forgot to
add a note to git-push(1) about the new --no-verify option.

Signed-off-by: Thomas Rast <redacted>
---

Junio replied privately that it should also mention the --verify
possibility.

So why not.  But this needs to be fixed across the board eventually;
0f1930c (parse-options: allow positivation of options starting, with
no-, 2012-02-25) did not update any docs, so none of the other --no-
options mention their positive forms.


 Documentation/git-push.txt | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
index d514813..df5be26 100644
--- a/Documentation/git-push.txt
+++ b/Documentation/git-push.txt

@@ -11,7 +11,7 @@ SYNOPSIS
 [verse]
 'git push' [--all | --mirror | --tags] [--follow-tags] [-n | --dry-run] [--receive-pack=<git-receive-pack>]
 	   [--repo=<repository>] [-f | --force] [--prune] [-v | --verbose] [-u | --set-upstream]
-	   [<repository> [<refspec>...]]
+	   [--no-verify] [<repository> [<refspec>...]]
 
 DESCRIPTION
 -----------

@@ -195,6 +195,11 @@ useful if you write an alias or script around 'git push'.
 	be pushed. If on-demand was not able to push all necessary
 	revisions it will also be aborted and exit with non-zero status.
 
+--[no-]verify::
+	Toggle the pre-push hook (see linkgit:githooks[5]).  The
+	default is \--verify, giving the hook a chance to prevent the
+	push.  With \--no-verify, the hook is bypassed completely.
+
 
 include::urls-remotes.txt[]
 

-- 
1.8.3.rc3.486.gfe16094

On Thu, May 23, 2013 at 03:34:11PM +0200, Thomas Rast wrote:

ec55559 (push: Add support for pre-push hooks, 2013-01-13) forgot to
add a note to git-push(1) about the new --no-verify option.

Signed-off-by: Thomas Rast <redacted>

Thanks. FWIW

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>