[PATCH v2] transport-helper: check if the dry-run is supported
From: Felipe Contreras <hidden>
Date: 2016-06-15 22:57:23
Subsystem:
the rest · Maintainer:
Linus Torvalds
Certain remote-helpers (the ones with 'export') would try to push regardless. Obviously this is not what the user wants. Also, add a check for the 'dry-run' option, so remote-helpers can implement it. Signed-off-by: Felipe Contreras <redacted> --- transport-helper.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/transport-helper.c b/transport-helper.c
index 522d791..c8c39fc 100644
--- a/transport-helper.c
+++ b/transport-helper.c@@ -789,6 +789,11 @@ static int push_refs_with_export(struct transport *transport, struct string_list revlist_args = STRING_LIST_INIT_NODUP; struct strbuf buf = STRBUF_INIT; + if (flags & TRANSPORT_PUSH_DRY_RUN) { + if (set_helper_option(transport, "dry-run", "true") != 0) + die("helper %s does not support dry-run", data->name); + } + helper = get_helper(transport); write_constant(helper->in, "export\n");
--
1.8.3.rc3.1.gf11a2b7.dirty