Felipe Contreras [off-list ref] writes:
On Thu, May 16, 2013 at 11:19 AM, Junio C Hamano [off-list ref] wrote:
quoted
Felipe Contreras [off-list ref] writes:
quoted
I find it extremely annoying that an obviously correct patch is not
merged...
A patch that receives "this breaks style" comments
*Invalid* "this breaks style" comments, because it doesn't break any
style mentioned in Documentation/CodingGuidelines.
As for more concrete guidelines, just imitate the existing code
(this is a good guideline, no matter which project you are
contributing to). It is always preferable to match the _local_
convention
The document does not spell out all the details, but that does not
mean you can ignore what others say and many find a sensible style
request.
On Thu, May 16, 2013 at 11:49 AM, Junio C Hamano [off-list ref] wrote:
Felipe Contreras [off-list ref] writes:
quoted
On Thu, May 16, 2013 at 11:19 AM, Junio C Hamano [off-list ref] wrote:
quoted
Felipe Contreras [off-list ref] writes:
quoted
I find it extremely annoying that an obviously correct patch is not
merged...
A patch that receives "this breaks style" comments
*Invalid* "this breaks style" comments, because it doesn't break any
style mentioned in Documentation/CodingGuidelines.
As for more concrete guidelines, just imitate the existing code
(this is a good guideline, no matter which project you are
contributing to). It is always preferable to match the _local_
convention
Do you want me to find places that follow the convention I used in my
patch? Since the alignment is not even mentioned in the
Documentation/CodingGuidelines I I'll find them for sure.
But you are not interested in me finding that my style follows the
_local_ convention. All you want is me to follow the style you want
without going through the motions of updating the coding guidelines
which would require comments from the community.
The document does not spell out all the details, but that does not
mean you can ignore what others say and many find a sensible style
request.
You don't know what's the point of a codding guideline? It's precisely
to avoid these discussions.
You find it sensible, I don't. And when people disagree, that's what
the guideline is for. But since there's no guideline all we have is
your opinion vs. mine. And if you are going to play the "I'm there
authority" card, I'm not playing.
Law is law, guidelines are guidelines, and opinions are worthless.
--
Felipe Contreras