2 messages, 2 authors, 2016-06-15 · open the first message on its own page
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:17
Felipe Contreras [off-list ref] writes:
I find it extremely annoying that an obviously correct patch is not merged...
A patch that receives "this breaks style" comments and its author stubbornly refusing to fix what others pointed out, especially when the patch itself _is_ about style, cannot be "an obviously correct" patch, can it?
From: Felipe Contreras <hidden>
Date: 2016-06-15 22:57:17
On Thu, May 16, 2013 at 11:19 AM, Junio C Hamano [off-list ref] wrote:
Felipe Contreras [off-list ref] writes:quoted
I find it extremely annoying that an obviously correct patch is not merged...A patch that receives "this breaks style" comments
*Invalid* "this breaks style" comments, because it doesn't break any style mentioned in Documentation/CodingGuidelines. If somebody dreamt about another style not mentioned in Documentation/CodingGuidelines after drinking too much coffe, that's irrelevant. The only relevant style is the defined style.
and its author stubbornly refusing to fix what others pointed out, especially when the patch itself _is_ about style, cannot be "an obviously correct" patch, can it?
The patch makes the code follow Documentation/CodingGuidelines. Period. -- Felipe Contreras