Re: [PATCH 4/4] t4300 (rebase): don't unnecessarily set GIT_TRACE
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:57:12
Ramkumar Ramachandra [off-list ref] writes:
A couple of tests execute 'git rebase' with GIT_TRACE set to 1, but this trace output is not used anywhere.
Isn't it shown in "t4300-*.sh -v" output to help the debugger?
quoted hunk
relevant to what we are testing. Signed-off-by: Ramkumar Ramachandra <redacted> --- t/t3400-rebase.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/t/t3400-rebase.sh b/t/t3400-rebase.sh index 0841a12..d0d9442 100755 --- a/t/t3400-rebase.sh +++ b/t/t3400-rebase.sh@@ -137,13 +137,13 @@ test_expect_success 'rebase a single mode change' ' test_chmod +x A && test_tick && git commit -m modechange && - GIT_TRACE=1 git rebase master + git rebase master ' test_expect_success 'rebase is not broken by diff.renames' ' test_config diff.renames copies && git checkout filemove && - GIT_TRACE=1 git rebase force-3way + git rebase force-3way ' test_expect_success 'setup: recover' '