Re: jn/config-ignore-inaccessible (Re: What's cooking in git.git (Apr 2013, #10; Mon, 29))

Jonathan Nieder [off-list ref] writes:

Thomas Rast wrote:

quoted

Junio C Hamano [off-list ref] writes:

quoted

quoted

* jn/config-ignore-inaccessible (2013-04-15) 1 commit
 - config: allow inaccessible configuration under $HOME

 When $HOME is misconfigured to point at an unreadable directory, we
 used to complain and die. This loosens the check.

 I do not think we agreed that this is a good idea, though.

As a data point: yesterday on IRC, two users complained that they each
had this problem.

  http://colabti.org/irclogger/irclogger_log/git?date=2013-05-03#l3022
  http://colabti.org/irclogger/irclogger_log/git?date=2013-05-03#l3111

I think the approach taken in the patch above is a good one.  If
/etc/gitconfig contains important configuration, it is still not
ignored, errors other than permissions reading ~/.gitconfig are
still fatal, and permissions errors accessing ~/.gitconfig are no
longer fatal because they are expected as something very common
in normal setups.

OK.  Let's cook it in 'next' for a while and then decide what to do
post 1.8.3; I am perfectly fine with making it graduate to 'master'
immediately after 1.8.3 if everybody thinks this is a good idea.

On Sat, May 04, 2013 at 08:55:39PM -0700, Junio C Hamano wrote:

quoted

quoted

  http://colabti.org/irclogger/irclogger_log/git?date=2013-05-03#l3022
  http://colabti.org/irclogger/irclogger_log/git?date=2013-05-03#l3111

I think the approach taken in the patch above is a good one.  If
/etc/gitconfig contains important configuration, it is still not
ignored, errors other than permissions reading ~/.gitconfig are
still fatal, and permissions errors accessing ~/.gitconfig are no
longer fatal because they are expected as something very common
in normal setups.

OK.  Let's cook it in 'next' for a while and then decide what to do
post 1.8.3; I am perfectly fine with making it graduate to 'master'
immediately after 1.8.3 if everybody thinks this is a good idea.

FWIW, I do think this is the best path. I don't like the complex "which
errors are fatal" rule, but I think it is easily the most practical
solution.

-Peff