[PATCH v2] path: Fix a sparse warning
From: Ramsay Jones <hidden>
Date: 2016-06-15 22:57:07
Subsystem:
the rest · Maintainer:
Linus Torvalds
On MinGW, sparse issues an "'get_st_mode_bits' not declared. Should
it be static?" warning. The MinGW and MSVC builds do not see the
declaration of this function, within git-compat-util.h, due to its
placement within an preprocessor conditional.
In order to suppress the warning, we simply move the declaration to
the top level of the header.
Signed-off-by: Ramsay Jones <redacted>
---
Hi Junio,
This used to be
[PATCH 2/6] path: Make the 'get_st_mode_bits' symbol a file static
but the change in implementation required a change in title.
This version simply moves the declaration so that the MinGW and
MSVC builds can see it.
ATB,
Ramsay Jones
git-compat-util.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/git-compat-util.h b/git-compat-util.h
index e955bb5..0e5e4f8 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h@@ -163,7 +163,6 @@ typedef long intptr_t; typedef unsigned long uintptr_t; #endif -int get_st_mode_bits(const char *path, int *mode); #if defined(__CYGWIN__) #undef _XOPEN_SOURCE #include <grp.h>
@@ -176,6 +175,8 @@ int get_st_mode_bits(const char *path, int *mode); #endif #endif +extern int get_st_mode_bits(const char *path, int *mode); + /* used on Mac OS X */ #ifdef PRECOMPOSE_UNICODE #include "compat/precompose_utf8.h"
--
1.8.2