Re: [PATCHv2 7/7] git grep: honor textconv by default

Michael J Gruber [off-list ref] writes:

BTW, textconv does not have to be slow - just use textconv-cache.

Right, thanks for reminding me about this, I had forgotten its existance ;-).

I'm still looking for a way to at least treat "git grep" and "git show
blob" the same way.

I agree they should be treated similarly.

- Implement the --textconv option but leave the default as is. I did
that for "git grep" already (just drop 7/7)

That seems sensible.

but it seems to be cumbersome for "git show blob". I have to recheck.

It should be possible to have a tri-state for the --[no-]textconv
option: unset, set to true or set to false. But the code sharing between
log, show and diff might make that non-trivial.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

Matthieu Moy venit, vidit, dixit 26.04.2013 15:23:

Michael J Gruber [off-list ref] writes:

quoted

BTW, textconv does not have to be slow - just use textconv-cache.

Right, thanks for reminding me about this, I had forgotten its existance ;-).

quoted

I'm still looking for a way to at least treat "git grep" and "git show
blob" the same way.

I agree they should be treated similarly.

quoted

- Implement the --textconv option but leave the default as is. I did
that for "git grep" already (just drop 7/7)

That seems sensible.

quoted

but it seems to be cumbersome for "git show blob". I have to recheck.

It should be possible to have a tri-state for the --[no-]textconv
option: unset, set to true or set to false. But the code sharing between
log, show and diff might make that non-trivial.

Right now it's a diffopt bit...

Michael